Update several string references which can be renamed by closure-compiler #5472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChadKillingsworth
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Just 1 nit probably applicable to all usages. Nice work @ChadKillingsworth !
|
I did search the entire code base for these type of usages, including:
This was all of them. |
aomarks
approved these changes
Feb 19, 2019
kevinpschaaf
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across a few path references in Polymer that were not reflected. For users who are not using the
EXPORT_ALLpolicy of closure compiler, the properties would have been renamed inconsistently.Once google/closure-compiler#3184 is merged, the compiler will be able to handle reflection of observer and computed properties paths. However references to paths within other code, such as those to
notifyPath, will still need to be manually reflected.